SansanandClaude Sonnet 5
5072919b61
Steps 1-4 of the review plan (docs/plans not checked in; see conversation):
Step 1 - make it boot from a clean checkout:
- Replace the old schema.sql + single ALTER-TABLE migration (which never
created the tables) with one init migration: users, sessions, platform,
game, all with UUIDv7-ready uuid ids, soft deletes (deleted_at), and a
shared change_seq sequence + trigger for a future sync feature.
- sqlc now reads the schema from db/migrations directly.
- Migrations are embedded in the binary (db/migrations/embed.go) instead of
being copied around and found via path fallbacks.
- ensureDatabase/runMigrations failures are now fatal, and main pings the
pool after connecting, instead of starting an API with no schema.
- Switched both the app and golang-migrate to pgx/v5 (dropped lib/pq).
- Fixed the Dockerfile's Go version (1.23 -> 1.25) and build target.
- Added a postgres healthcheck to docker-compose so the app waits for a
ready database instead of racing it.
- go.mod tidied, bin/ added to .gitignore, Justfile's docker-compose calls
switched to the v2 `docker compose` plugin.
Step 2 - auth and per-user data:
- internal/auth: argon2id password hashing, random session tokens stored
only as a hash.
- POST /api/auth/{register,login,logout}, GET /api/auth/me. Sessions work
via either an Authorization: Bearer header or an httpOnly cookie.
- Every platform/game query is scoped to the authenticated user.
Step 3 - API correctness:
- internal/model holds the DTOs, with no server-side dependencies, so
clients can import it later without pulling in Huma/Echo.
- dbError() maps ErrNoRows -> 404, unique violation -> 409, FK violation ->
409, instead of leaking Postgres error text with a 500.
- Soft-delete meant the FK on game.platform_id no longer blocks deleting a
referenced platform on its own; added a NOT EXISTS guard plus an
application-level check so that case now correctly returns 409 instead of
silently succeeding (caught by testing the live server, not by a mock).
- Added GET /games/{id} and GET /platforms/{id}. All JSON routes moved
under /api, freeing / for a future web client.
- ListGames/GetGame join platform_name in.
- cmd/openapi writes the generated spec to api/openapi.json.
Step 4 - tests and CI:
- Rewrote the mocks and handler tests for the new Querier shape; added
coverage for 401 (no session), 404 (not found / another user's row),
409 (duplicate email, platform referenced by games), 422 (score out of
range), and that queries are actually scoped by the authenticated user's
id, not just that the right status code comes back.
- .github/workflows/ci.yml: go vet, go test, go mod tidy -diff, sqlc diff.
Everything above was exercised against a real local Postgres (migrations
up/down, the trigger, constraints) and through the running server via curl
(register, login, scoping, every status-code case), not just unit tests.
Known regression, intentionally deferred to the next step: cmd/tui and
cmd/gui still call the old unauthenticated GET /games, which no longer
exists. They need internal/client and a login flow before they work again.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
53 lines
1.5 KiB
Go
53 lines
1.5 KiB
Go
package api
|
|
|
|
import (
|
|
"errors"
|
|
"log"
|
|
|
|
"github.com/danielgtaylor/huma/v2"
|
|
"github.com/jackc/pgx/v5"
|
|
"github.com/jackc/pgx/v5/pgconn"
|
|
)
|
|
|
|
// Postgres error codes this package maps to specific HTTP statuses.
|
|
// See https://www.postgresql.org/docs/current/errcodes-appendix.html
|
|
const (
|
|
pgCodeUniqueViolation = "23505"
|
|
pgCodeForeignKeyViolation = "23503"
|
|
)
|
|
|
|
// dbError turns a database error into the huma error a handler should
|
|
// return, so Postgres's own error text never reaches a client and callers
|
|
// get the right HTTP status instead of a generic 500.
|
|
func dbError(err error) error {
|
|
if errors.Is(err, pgx.ErrNoRows) {
|
|
return huma.Error404NotFound("not found")
|
|
}
|
|
|
|
var pgErr *pgconn.PgError
|
|
if errors.As(err, &pgErr) {
|
|
switch pgErr.Code {
|
|
case pgCodeUniqueViolation:
|
|
return huma.Error409Conflict("already exists")
|
|
case pgCodeForeignKeyViolation:
|
|
// A foreign key failure here is either a reference to a platform
|
|
// that doesn't exist (create/update) or a delete blocked by
|
|
// games that still reference this platform.
|
|
return huma.Error409Conflict("referenced by another record, or refers to one that doesn't exist")
|
|
}
|
|
}
|
|
|
|
log.Printf("unmapped database error: %v", err)
|
|
return huma.Error500InternalServerError("internal error")
|
|
}
|
|
|
|
// notFoundIfZero turns the "0 rows affected" result of a soft-delete
|
|
// UPDATE into a 404, since the row either never existed or was already
|
|
// deleted.
|
|
func notFoundIfZero(rows int64) error {
|
|
if rows == 0 {
|
|
return huma.Error404NotFound("not found")
|
|
}
|
|
return nil
|
|
}
|