Name popups *Popup and give scripts, scenes and classes matching names

Every popup is now called *Popup instead of *Window in its file, root node,
node name, class and variable, and PopupWindow becomes BasePopup. Player is
PlayerRow, SongListObject is SongRow and Character is CharacterCard. Script
files are snake_case and scene files PascalCase, each matching its class or
root node, and LightGrayTheme.tres is light_gray_theme.tres.

tests/integration/test_scene_split.gd

@@ -5,8 +5,8 @@ extends MainWindowTestSuite
 ## server and the keyboard shortcuts reach both the main window and the quiz.
 
 const MAIN_WINDOW_CHILDREN: Array[String] = [
-	"TopBar", "Quiz", "PopupBackdrop", "Search", "SyncWindow", "QRWindow",
-	"ShortcutsWindow", "StatisticsPopupPanel", "AboutWindow", "Log",
+	"TopBar", "Quiz", "PopupBackdrop", "SearchPopup", "SyncPopup", "QRPopup",
+	"ShortcutsPopup", "StatisticsPopupPanel", "AboutPopup", "LogPopup",
 ]
 
 const TOP_BAR_CHILDREN: Array[String] = [
@@ -16,12 +16,12 @@ const TOP_BAR_CHILDREN: Array[String] = [
 
 ## Each top bar button and the popup it opens in the main window.
 const TOP_BAR_POPUPS: Dictionary = {
-	"SearchButton": "Search",
-	"SyncButton": "SyncWindow",
+	"SearchButton": "SearchPopup",
+	"SyncButton": "SyncPopup",
 	"StatisticsButton": "StatisticsPopupPanel",
-	"ShortcutsButton": "ShortcutsWindow",
-	"AboutButton": "AboutWindow",
-	"QRButton": "QRWindow",
+	"ShortcutsButton": "ShortcutsPopup",
+	"AboutButton": "AboutPopup",
+	"QRButton": "QRPopup",
 }
 
 
@@ -85,7 +85,7 @@ func test_clicking_each_top_bar_button_opens_its_popup() -> void:
 
 		assert_bool(popup.visible).override_failure_message(
 				"%s did not open %s" % [button_name, popup.name]).is_true()
-		if popup is PopupWindow:
+		if popup is BasePopup:
 			popup.close()
 		else:
 			popup.visible = false
@@ -115,7 +115,7 @@ func test_clicking_a_song_in_the_music_list_plays_it() -> void:
 	var rows: Array[Node] = _quiz.get_node("MusicListPanel/ScrollContainer/MusicList") \
 			.get_children()
 	var first_row: Control = rows.filter(
-			func(row: SongListObject) -> bool: return row.song_object.song_number == 0)[0]
+			func(row: SongRow) -> bool: return row.song_object.song_number == 0)[0]
 
 	await _click_at(first_row.get_global_rect().position + Vector2(20, first_row.size.y / 2))
 	await get_tree().create_timer(0.7).timeout
@@ -130,13 +130,13 @@ func test_points_from_the_player_list_reach_the_song_and_log() -> void:
 	(_player_row(crono).get_node("HBoxContainer/AddPoint") as BaseButton).pressed.emit()
 
 	assert_array(Playlist.song_object_array[0].players_given_point).contains_exactly([crono.id])
-	assert_int((_window.get_node("%Log").get_node("%LogVBoxContainer") as Node).get_child_count()) \
+	assert_int((_window.get_node("%LogPopup").get_node("%LogVBoxContainer") as Node).get_child_count()) \
 			.is_equal(1)
 
 
 func test_character_button_in_the_player_list_picks_a_new_character() -> void:
 	var crono: PlayerObject = _add_player("Crono")
-	var character_select: PopupWindow = _quiz.get_node("NewCharacterSelect")
+	var character_select: BasePopup = _quiz.get_node("CharacterSelectPopup")
 
 	(_player_row(crono).get_node("HBoxContainer/Character") as BaseButton).pressed.emit()
 
@@ -167,12 +167,12 @@ func test_loaded_song_list_shows_in_the_music_list() -> void:
 	_quiz.song_loader.load_song_list()
 
 	var rows: Array[Node] = _quiz.get_node("MusicListPanel/ScrollContainer/MusicList").get_children()
-	assert_array(rows.map(func(row: SongListObject) -> int: return row.song_object.song_number)) \
+	assert_array(rows.map(func(row: SongRow) -> int: return row.song_object.song_number)) \
 			.contains_exactly([0, 1])
 
 
 func test_quiz_popup_backdrop_covers_the_top_bar() -> void:
-	var settings: PopupWindow = _quiz.get_node("SettingsWindow")
+	var settings: BasePopup = _quiz.get_node("SettingsPopup")
 	settings.open()
 	await _runner.simulate_frames(1)
 
@@ -184,8 +184,8 @@ func test_quiz_popup_backdrop_covers_the_top_bar() -> void:
 
 
 func test_click_on_top_bar_while_quiz_popup_is_open_only_closes_it() -> void:
-	var settings: PopupWindow = _quiz.get_node("SettingsWindow")
-	var search: PopupWindow = _window.get_node("Search")
+	var settings: BasePopup = _quiz.get_node("SettingsPopup")
+	var search: BasePopup = _window.get_node("SearchPopup")
 	settings.open()
 	await _runner.simulate_frames(1)
 
@@ -198,10 +198,10 @@ func test_click_on_top_bar_while_quiz_popup_is_open_only_closes_it() -> void:
 func test_sync_disables_quiz_buttons_until_finished() -> void:
 	_server.respond_bytes("/sync", PackedByteArray())
 	_server.respond_json("/sync/progress", {"progress": 10, "time_spent": "00:00:01"})
-	var sync_window: PopupWindow = _window.get_node("SyncWindow")
+	var sync_popup: BasePopup = _window.get_node("SyncPopup")
 
 	_top_bar_button("SyncButton").pressed.emit()
-	sync_window.sync_timer.stop()
+	sync_popup.sync_timer.stop()
 
 	for button_name: String in ["QuizToolbar/SoundTestButton", "QuizToolbar/ResetPlaylistButton", "SongControls/ShowAnswerButton",
 			"SongControls/NextButton"]:
@@ -211,7 +211,7 @@ func test_sync_disables_quiz_buttons_until_finished() -> void:
 
 	_server.respond_json("/sync/progress", UiTour.SYNC_RESULT)
 	var reloads_before: int = _server.count("/music/all/order")
-	sync_window._on_sync_timeout()
+	sync_popup._on_sync_timeout()
 	await _runner.simulate_frames(2)
 
 	for button_name: String in ["QuizToolbar/SoundTestButton", "QuizToolbar/ResetPlaylistButton", "SongControls/ShowAnswerButton",
@@ -229,7 +229,7 @@ func test_changing_server_reloads_search_and_quiz() -> void:
 	var player: PlayerObject = _add_player("Crono")
 	player.add_point()
 
-	_quiz.get_node("SettingsWindow").server_changed.emit()
+	_quiz.get_node("SettingsPopup").server_changed.emit()
 
 	assert_int(_server.count("/music/all/order")).is_equal(search_loads + 1)
 	assert_int(_server.count("/music/all")).is_equal(inspiration_loads + 1)
@@ -239,10 +239,10 @@ func test_changing_server_reloads_search_and_quiz() -> void:
 
 func test_alt_k_opens_shortcuts_and_alt_l_opens_log() -> void:
 	await _press_keys([KEY_ALT, KEY_K])
-	assert_bool((_window.get_node("ShortcutsWindow") as Control).visible).is_true()
+	assert_bool((_window.get_node("ShortcutsPopup") as Control).visible).is_true()
 
 	await _press_keys([KEY_ALT, KEY_L])
-	assert_bool((_window.get_node("Log") as Control).visible).is_true()
+	assert_bool((_window.get_node("LogPopup") as Control).visible).is_true()
 
 
 func test_alt_down_lowers_the_volume() -> void:
@@ -258,7 +258,7 @@ func test_alt_down_lowers_the_volume() -> void:
 
 
 func test_alt_enter_switches_fullscreen_and_settings_shows_it() -> void:
-	var settings: PopupWindow = _quiz.get_node("SettingsWindow")
+	var settings: BasePopup = _quiz.get_node("SettingsPopup")
 	var was_fullscreen: bool = Settings.fullscreen
 
 	await _press_keys([KEY_ALT, KEY_ENTER])