Move server calls to MusicServerClient and give players stable ids
Server requests move out of Settings into a new MusicServerClient autoload with one function per endpoint. It sends requests through a swappable HttpTransport so tests can fake the server, and it frees its HTTPRequest nodes after use. Players now have a UUID that never changes. Their position in Settings.player_array is only used for the Alt+<number> keybinds. Previously the position doubled as the id, so removing a player made points and wins land on the wrong player, and could delete another player's point from a song. Also fixes: - format_time showed 59.6 seconds as "00:60" - searches containing regex characters such as "Q*bert" broke search - SongObject and PlayerObject were Nodes that were never freed; they are now RefCounted - search matching is split out of the UI code into find_matches()
This commit is contained in:
1 parent
ab338b0696
commit
56e9fe66d3
18 files changed
+281
-162
No files matched your search
@@ -23,6 +23,7 @@ config/icon="res://icon.svg"
|
||||
|
||||
Settings="*res://Settings.gd"
|
||||
Playlist="*res://playlist.gd"
|
||||
MusicServerClient="*res://music_server_client.gd"
|
||||
|
||||
[debug]
|
||||
|
||||
|
||||
Reference in new issue
Block a user