Move the log popup to the main window

The quiz reports point changes with an event_logged signal, and the main
window adds them to the log. Alt+L is handled by the main window.
This commit is contained in:
Sansan committed 2026-10-06 11:13:11 +02:00
1 parent e94c75e84d
commit 5cdec5cc8f
8 files changed
+30 -27

No files matched your search

+1 -1
View File
@@ -13,7 +13,7 @@ const BASELINE_PATH: String = "res://tests/data/layout_baseline.json"
## Nodes that moved from the main window into the Quiz scene, by their old name.
const QUIZ_NODES: Array[String] = [
"Open", "FileDialog", "MusicListPanel", "DebugLabel", "SettingsWindow",
"NewCharacterSelect", "WinnerWindow", "Log",
"NewCharacterSelect", "WinnerWindow",
]
## Nodes that moved into the Quiz scene under another path: old name to new path in
+1 -1
View File
@@ -229,7 +229,7 @@ func test_show_answer_before_first_song_does_not_reveal_next_song() -> void:
func test_log_adds_one_row_per_point_with_padded_time() -> void:
var log_box: VBoxContainer = _quiz.get_node("%Log").get_node("%LogVBoxContainer")
var log_box: VBoxContainer = _window.get_node("%Log").get_node("%LogVBoxContainer")
var crono: PlayerObject = _add_player("Crono")
await _play_first_song()
+3 -3
View File
@@ -3,14 +3,14 @@ extends MainWindowTestSuite
## dims the window behind them, and the closing click does not reach the main window.
## The main window and the quiz each have their own popups and their own backdrop.
## Popups opened from the top bar, in the main window.
## Popups in the main window: the ones opened from the top bar, and the log.
const MAIN_POPUPS: Array[String] = [
"Search", "SyncWindow", "QRWindow", "ShortcutsWindow", "AboutWindow",
"Search", "SyncWindow", "QRWindow", "ShortcutsWindow", "AboutWindow", "Log",
]
## Popups opened from the quiz, in the Quiz scene.
const QUIZ_POPUPS: Array[String] = [
"SettingsWindow", "NewCharacterSelect", "WinnerWindow", "Log",
"SettingsWindow", "NewCharacterSelect", "WinnerWindow",
]
+3 -3
View File
@@ -6,7 +6,7 @@ extends MainWindowTestSuite
const MAIN_WINDOW_CHILDREN: Array[String] = [
"TopBar", "Quiz", "PopupBackdrop", "Search", "SyncWindow", "QRWindow",
"ShortcutsWindow", "StatisticsPopupPanel", "AboutWindow",
"ShortcutsWindow", "StatisticsPopupPanel", "AboutWindow", "Log",
]
const TOP_BAR_CHILDREN: Array[String] = [
@@ -130,7 +130,7 @@ func test_points_from_the_player_list_reach_the_song_and_log() -> void:
(_player_row(crono).get_node("HBoxContainer/AddPoint") as BaseButton).pressed.emit()
assert_array(Playlist.song_object_array[0].players_given_point).contains_exactly([crono.id])
assert_int((_quiz.get_node("%Log").get_node("%LogVBoxContainer") as Node).get_child_count()) \
assert_int((_window.get_node("%Log").get_node("%LogVBoxContainer") as Node).get_child_count()) \
.is_equal(1)
@@ -242,7 +242,7 @@ func test_alt_k_opens_shortcuts_and_alt_l_opens_log() -> void:
assert_bool((_window.get_node("ShortcutsWindow") as Control).visible).is_true()
await _press_keys([KEY_ALT, KEY_L])
assert_bool((_quiz.get_node("Log") as Control).visible).is_true()
assert_bool((_window.get_node("Log") as Control).visible).is_true()
func test_alt_down_lowers_the_volume() -> void: