Add GET /api/v1/download/linux-package
CI / docker (push) Failing after 20s
CI / test (push) Successful in 23s
CI / integration (push) Successful in 25s
CI / publish (push) Skipped

Redirects to the newest MusicPlayer release's _linux.tar.gz, which has the
icon, a menu entry and install.sh. /download/linux keeps serving the bare
.x86_64, which updating in place needs. Releases without the package get 404.

Closes #34

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
SansanandClaude Opus 5.5 committed 2026-10-15 19:40:22 +02:00
1 parent bb8de5548d
commit c70eb4d13c
4 files changed
+44

No files matched your search

+20
View File
@@ -52,6 +52,26 @@ func TestReleaseService(t *testing.T) {
assert.ErrorIs(t, err, ErrNotFound) assert.ErrorIs(t, err, ErrNotFound)
} }
func TestReleaseServiceLinuxBinaryAndPackage(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
json.NewEncoder(w).Encode(giteaRelease{Id: 1, Name: "v1.9.0", Assets: []giteaAsset{
{Name: "MusicPlayer_1.9.0.exe", DownloadUrl: "https://example.com/exe"},
{Name: "MusicPlayer_1.9.0_linux.tar.gz", DownloadUrl: "https://example.com/package"},
{Name: "MusicPlayer_1.9.0.x86_64", DownloadUrl: "https://example.com/binary"},
}})
}))
t.Cleanup(server.Close)
r := NewReleaseService(server.URL)
ctx := context.Background()
binary, err := r.AssetURL(ctx, ".x86_64")
require.NoError(t, err)
assert.Equal(t, "https://example.com/binary", binary)
pkg, err := r.AssetURL(ctx, "_linux.tar.gz")
require.NoError(t, err)
assert.Equal(t, "https://example.com/package", pkg)
}
func TestReleaseServiceCachesRelease(t *testing.T) { func TestReleaseServiceCachesRelease(t *testing.T) {
server, calls := newGitea(t, http.StatusOK) server, calls := newGitea(t, http.StatusOK)
r := NewReleaseService(server.URL) r := NewReleaseService(server.URL)
+20
View File
@@ -222,7 +222,27 @@ func TestDownloadEndpoints(t *testing.T) {
assert.Equal(t, http.StatusFound, rec.Code) assert.Equal(t, http.StatusFound, rec.Code)
assert.Equal(t, "https://example.com/Player.exe", rec.Header().Get("Location")) assert.Equal(t, "https://example.com/Player.exe", rec.Header().Get("Location"))
// A release without Linux files, like those before 1.9.
assert.Equal(t, http.StatusNotFound, e.do(http.MethodGet, "/api/v1/download/linux").Code) assert.Equal(t, http.StatusNotFound, e.do(http.MethodGet, "/api/v1/download/linux").Code)
assert.Equal(t, http.StatusNotFound, e.do(http.MethodGet, "/api/v1/download/linux-package").Code)
}
func TestDownloadLinuxBinaryAndPackage(t *testing.T) {
gitea := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Write([]byte(`{"id":1,"name":"v1.9.0","assets":[` +
`{"name":"MusicPlayer_1.9.0_linux.tar.gz","browser_download_url":"https://example.com/package"},` +
`{"name":"MusicPlayer_1.9.0.x86_64","browser_download_url":"https://example.com/binary"}]}`))
}))
t.Cleanup(gitea.Close)
e := newTestEnv(t, func(c *config.Config) { c.ReleasesURL = gitea.URL })
rec := e.do(http.MethodGet, "/api/v1/download/linux")
assert.Equal(t, http.StatusFound, rec.Code)
assert.Equal(t, "https://example.com/binary", rec.Header().Get("Location"), "the bare binary, for updating in place")
rec = e.do(http.MethodGet, "/api/v1/download/linux-package")
assert.Equal(t, http.StatusFound, rec.Code)
assert.Equal(t, "https://example.com/package", rec.Header().Get("Location"))
} }
func TestDownloadUpstreamDown(t *testing.T) { func TestDownloadUpstreamDown(t *testing.T) {
+2
View File
@@ -102,4 +102,6 @@ func (s *Server) registerMisc(a huma.API) {
} }
download("download-client-windows", "/download/windows", "Windows", ".exe") download("download-client-windows", "/download/windows", "Windows", ".exe")
download("download-client-linux", "/download/linux", "Linux", ".x86_64") download("download-client-linux", "/download/linux", "Linux", ".x86_64")
// The package has the icon, a menu entry and install.sh. Releases before 1.9 have none (404).
download("download-client-linux-package", "/download/linux-package", "Linux (package with installer)", "_linux.tar.gz")
} }
+2
View File
@@ -81,6 +81,7 @@ func TestOpenAPIDocumentsTheV1API(t *testing.T) {
"GET /api/v1/character/list", "GET /api/v1/character/list",
"GET /api/v1/download", "GET /api/v1/download",
"GET /api/v1/download/linux", "GET /api/v1/download/linux",
"GET /api/v1/download/linux-package",
"GET /api/v1/download/list", "GET /api/v1/download/list",
"GET /api/v1/download/windows", "GET /api/v1/download/windows",
"GET /api/v1/health", "GET /api/v1/health",
@@ -235,6 +236,7 @@ func TestResponsesMatchOpenAPI(t *testing.T) {
v.check(http.MethodGet, "/api/v1/download/list", "", http.StatusOK) v.check(http.MethodGet, "/api/v1/download/list", "", http.StatusOK)
v.check(http.MethodGet, "/api/v1/download/windows", "", http.StatusFound) v.check(http.MethodGet, "/api/v1/download/windows", "", http.StatusFound)
v.check(http.MethodGet, "/api/v1/download/linux", "", http.StatusNotFound) v.check(http.MethodGet, "/api/v1/download/linux", "", http.StatusNotFound)
v.check(http.MethodGet, "/api/v1/download/linux-package", "", http.StatusNotFound)
v.check(http.MethodGet, "/api/v1/health", "", http.StatusOK) v.check(http.MethodGet, "/api/v1/health", "", http.StatusOK)
v.check(http.MethodGet, "/api/v1/version", "", http.StatusOK) v.check(http.MethodGet, "/api/v1/version", "", http.StatusOK)
v.check(http.MethodGet, "/api/v1/version/history", "", http.StatusOK) v.check(http.MethodGet, "/api/v1/version/history", "", http.StatusOK)