Sansan
090e794460
Security - Serve character images through os.Root so names like ../ can't escape the characters folder - Sync start and /sync/reset are POST only (legacy and /api/v1) - /api/v1/token/cleanup requires a token, password compared in constant time, tokens no longer logged - Echo's rate limiter replaces the custom one; TRUSTED_PROXIES enables X-Forwarded-For for reverse proxies Crashes and races - Sync state lives in SyncService with atomics and a mutex instead of unsynchronised globals (fixes concurrent map writes during full sync) - Only one sync can run; /api/v1 sync and music routes are locked during sync like the legacy ones - No log.Fatal outside startup: errors become 4xx/5xx responses - Search uses an in-order character match instead of unescaped regexes - Empty queue / no songs return 404 instead of panicking or looping Behaviour - Sync result is computed once and stays the same between polls - Swagger and /openapi serve the embedded spec - Shutdown stops HTTP before closing the database - Expired tokens are deleted with a context that outlives the request - Files are served with Range support and correct content types; audio has no write deadline Performance - Migration 000006 adds soundtrack.fingerprint (names, sizes, mtimes) so unchanged folders are skipped without reading any files - Songs are reconciled per soundtrack with one query plus needed writes; renames keep play counts - Moved MUSIC_PATH updates soundtrack and song paths - .id cleanup only runs for changed soundtracks or a full sync - Classic random uses one SQL query; Gitea release lookups are cached with a timeout Structure - internal/config reads all environment variables once - sqlc emits a Querier interface; backend globals become services injected into handlers - One route registration shared by legacy and /api/v1 - Removed dead code (dbHelper.go, unused middleware, duplicate Gitea functions, embedded Swagger UI copy) and lib/pq - templ and swag pinned as go tools
52 lines
1.3 KiB
Go
52 lines
1.3 KiB
Go
package server
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"music-server/internal/backend"
|
|
|
|
"github.com/labstack/echo/v5"
|
|
)
|
|
|
|
type CharacterHandler struct {
|
|
characters *backend.CharacterService
|
|
}
|
|
|
|
func NewCharacterHandler(characters *backend.CharacterService) *CharacterHandler {
|
|
return &CharacterHandler{characters: characters}
|
|
}
|
|
|
|
// GetCharacterList godoc
|
|
// @Summary Get list of characters
|
|
// @Description Returns a list of all available characters
|
|
// @Tags characters
|
|
// @Produce json
|
|
// @Success 200 {array} string
|
|
// @Router /characters [get]
|
|
func (c *CharacterHandler) GetCharacterList(ctx *echo.Context) error {
|
|
characters, err := c.characters.List()
|
|
if err != nil {
|
|
return songError(err)
|
|
}
|
|
return ctx.JSON(http.StatusOK, characters)
|
|
}
|
|
|
|
// GetCharacter godoc
|
|
// @Summary Get character image
|
|
// @Description Returns the image for a specific character
|
|
// @Tags characters
|
|
// @Produce image/png
|
|
// @Produce image/jpeg
|
|
// @Param name query string true "Character file name"
|
|
// @Success 200 {file} file
|
|
// @Failure 400 {string} string "invalid name"
|
|
// @Failure 404 {string} string "not found"
|
|
// @Router /character [get]
|
|
func (c *CharacterHandler) GetCharacter(ctx *echo.Context) error {
|
|
f, err := c.characters.Open(ctx.QueryParam("name"))
|
|
if err != nil {
|
|
return songError(err)
|
|
}
|
|
return serveFile(ctx, f, "")
|
|
}
|