Sansan
090e794460
Security - Serve character images through os.Root so names like ../ can't escape the characters folder - Sync start and /sync/reset are POST only (legacy and /api/v1) - /api/v1/token/cleanup requires a token, password compared in constant time, tokens no longer logged - Echo's rate limiter replaces the custom one; TRUSTED_PROXIES enables X-Forwarded-For for reverse proxies Crashes and races - Sync state lives in SyncService with atomics and a mutex instead of unsynchronised globals (fixes concurrent map writes during full sync) - Only one sync can run; /api/v1 sync and music routes are locked during sync like the legacy ones - No log.Fatal outside startup: errors become 4xx/5xx responses - Search uses an in-order character match instead of unescaped regexes - Empty queue / no songs return 404 instead of panicking or looping Behaviour - Sync result is computed once and stays the same between polls - Swagger and /openapi serve the embedded spec - Shutdown stops HTTP before closing the database - Expired tokens are deleted with a context that outlives the request - Files are served with Range support and correct content types; audio has no write deadline Performance - Migration 000006 adds soundtrack.fingerprint (names, sizes, mtimes) so unchanged folders are skipped without reading any files - Songs are reconciled per soundtrack with one query plus needed writes; renames keep play counts - Moved MUSIC_PATH updates soundtrack and song paths - .id cleanup only runs for changed soundtracks or a full sync - Classic random uses one SQL query; Gitea release lookups are cached with a timeout Structure - internal/config reads all environment variables once - sqlc emits a Querier interface; backend globals become services injected into handlers - One route registration shared by legacy and /api/v1 - Removed dead code (dbHelper.go, unused middleware, duplicate Gitea functions, embedded Swagger UI copy) and lib/pq - templ and swag pinned as go tools
63 lines
1.9 KiB
Go
63 lines
1.9 KiB
Go
package middleware
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"strings"
|
|
"time"
|
|
|
|
"music-server/internal/db/repository"
|
|
"music-server/internal/logging"
|
|
|
|
"github.com/labstack/echo/v5"
|
|
"go.uber.org/zap"
|
|
)
|
|
|
|
// BearerToken extracts the token from an "Authorization: Bearer <token>" header.
|
|
func BearerToken(c *echo.Context) (string, bool) {
|
|
token, ok := strings.CutPrefix(c.Request().Header.Get("Authorization"), "Bearer ")
|
|
return token, ok && token != "" && !strings.Contains(token, " ")
|
|
}
|
|
|
|
// TokenAuth validates session tokens. When disabled is true all requests are let through.
|
|
func TokenAuth(q repository.Querier, disabled bool) echo.MiddlewareFunc {
|
|
return func(next echo.HandlerFunc) echo.HandlerFunc {
|
|
return func(c *echo.Context) error {
|
|
if disabled {
|
|
return next(c)
|
|
}
|
|
|
|
if c.Request().Header.Get("Authorization") == "" {
|
|
return c.JSON(http.StatusUnauthorized, map[string]string{"error": "Authorization header required"})
|
|
}
|
|
token, ok := BearerToken(c)
|
|
if !ok {
|
|
return c.JSON(http.StatusUnauthorized, map[string]string{"error": "Invalid authorization format. Use: Bearer <token>"})
|
|
}
|
|
|
|
ctx := c.Request().Context()
|
|
session, err := q.GetSession(ctx, token)
|
|
if err != nil {
|
|
logging.GetLogger().Warn("Invalid token attempt",
|
|
zap.String("ip", c.RealIP()),
|
|
zap.String("error", err.Error()),
|
|
)
|
|
return c.JSON(http.StatusUnauthorized, map[string]string{"error": "Invalid or expired token"})
|
|
}
|
|
|
|
if time.Now().After(session.ExpiresAt.Time) {
|
|
// Clean up in the background with a context that outlives the request.
|
|
go func(ctx context.Context) {
|
|
if err := q.DeleteSession(ctx, token); err != nil {
|
|
logging.GetLogger().Error("Failed to delete expired session", zap.Error(err))
|
|
}
|
|
}(context.WithoutCancel(ctx))
|
|
return c.JSON(http.StatusUnauthorized, map[string]string{"error": "Token expired"})
|
|
}
|
|
|
|
c.Set("session", session)
|
|
return next(c)
|
|
}
|
|
}
|
|
}
|